From 96776c9f8d832aadd37796cfa4fbd7b66e6f491e Mon Sep 17 00:00:00 2001 From: "claude[bot]" <41898282+claude[bot]@users.noreply.github.com> Date: Fri, 24 Apr 2026 04:15:43 +0000 Subject: [PATCH] fix: check disabled flag in global shortcut handler The global shortcut handler never checked the `disabled` property on shortcut objects, causing disabled shortcuts to still intercept browser keystrokes via preventDefault(). This meant browser shortcuts like Ctrl+Shift+B (bookmarks bar) were always hijacked even when the app shortcut was disabled. Fixes #1079 Co-authored-by: Enrico Ros --- src/common/components/shortcuts/globalShortcutsHandler.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/common/components/shortcuts/globalShortcutsHandler.ts b/src/common/components/shortcuts/globalShortcutsHandler.ts index 355e83507..5173a37fb 100644 --- a/src/common/components/shortcuts/globalShortcutsHandler.ts +++ b/src/common/components/shortcuts/globalShortcutsHandler.ts @@ -37,6 +37,10 @@ function _handleGlobalShortcutKeyDown(event: KeyboardEvent) { (shortcut.shift && !event.shiftKey) || (!shortcut.shift && event.shiftKey)) continue; + // Skip disabled shortcuts - let the browser handle the keystroke + if (shortcut.disabled) + continue; + // Skip if a text input element is focused and the shortcut opts into this guard if (shortcut.skipIfInput && _isTextInputFocused()) continue;